feat(faseF2): DELTIX_ENABLE_GRPC_TRANSFER flag gates legacy gRPC pull - #21
Merged
Conversation
…pull Native commit-based pull (Fase C) is now the default. To allow a safe rollback while it is confirmed in production, the old whole-file gRPC pull is kept behind an opt-in feature flag: - env: DELTIX_ENABLE_GRPC_TRANSFER (default false). - 'deltix pull <repo> <file>' uses the legacy gRPC DataflowService.pull only when the flag is on AND a destination file is passed; otherwise the native REST pull runs. Dataflow is a lazy import so it only loads when used. Marked transitional: the gRPC pull path is removed in a later phase once the native path is confirmed. 113 unit tests pass, build + lint clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keeps the old whole-file gRPC pull available behind an opt-in feature flag so the native commit-based pull (Fase C) can be rolled back/compared until confirmed, then removed.
Changes
DELTIX_ENABLE_GRPC_TRANSFER(defaultfalse).deltix pull <repo> <file>: routes to the legacy gRPCDataflowService.pullonly when the flag is on and a destination file is passed; otherwise the native REST pull runs. Dataflow is a lazyimport()so it only loads when used.Notes